Skip to content

chore(integration): fix failing tests referencing workspace_owner.rbac_roles #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 19, 2025

The tests updated in #330 may have worked initially when run against coder-preview:latest but that's a moving target.

Updates existing test to make no assertions (empty regexp) and adds a new test specifically for rbac roles field. Yes, it's a janky regex.
Ideally we'd have a way to:

  1. Conditionally assert specific fields of resources.
  2. Do JSON-ish assertions.

Closes #367

@johnstcn johnstcn self-assigned this Mar 19, 2025
@johnstcn johnstcn requested review from mafredri and Emyrk March 19, 2025 14:32
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, although I didn't spend a lot of time verifying it. Thanks for fixing 👍🏻

@johnstcn johnstcn merged commit f75fb0b into main Mar 19, 2025
6 checks passed
@johnstcn johnstcn deleted the cj/fix-workspace-owner-rbac-roles branch March 19, 2025 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants